Add messages to hook result. #21 #23
Conversation
ghost
assigned 
BugDiver
force-pushed
the
custom_messages
branch
from
34879af to
bd27838
Compare
| @@ -44,7 +45,8 @@ public override Message Process(Message request) | |||
| if (debuggingEnv != null && debuggingEnv.ToLower().Equals("true")) | |||
| { | |||
| // if the runner is launched in DEBUG mode, let the debugger attach. | |||
| System.Console.WriteLine("Runner Ready for Debugging at Process ID " + System.Diagnostics.Process.GetCurrentProcess().Id); | |||
| Console.WriteLine("Runner Ready for Debugging at Process ID " + | |||
| System.Diagnostics.Process.GetCurrentProcess().Id); | |||
There was a problem hiding this comment.
can be Process.GetCurrentProcess since System.Diagnostics is already in using.
There was a problem hiding this comment.
That creates name collision with the method name (Process).
| @@ -64,38 +64,6 @@ public void Setup() | |||
| }; | |||
| } | |||
|
|
|||
| //[BeforeScenario("Foo")] | |||
There was a problem hiding this comment.
This wasn't commented code :) - this bit of code block was to indicate what is the logic being tested. It was to ease the data setup. Perhaps you can add a line describing such, but i prefer we leave this in place.
| @@ -56,42 +56,6 @@ IHookMethod Create(string name, int aggregation = 0, params string[] tags) | |||
| }; | |||
| } | |||
|
|
|||
| //[AfterScenario("Foo")] | |||
There was a problem hiding this comment.
This bit of code block was to indicate what is the logic being tested. It was to ease the data setup. Perhaps you can add a line describing such, but i prefer we leave this in place.
| @@ -55,43 +55,6 @@ IHookMethod Create(string name, int aggregation = 0, params string[] tags) | |||
| }; | |||
| } | |||
|
|
|||
|
|
|||
| //[AfterScenario("Foo")] | |||
There was a problem hiding this comment.
This bit of code block was to indicate what is the logic being tested. It was to ease the data setup. Perhaps you can add a line describing such, but i prefer we leave this in place.
BugDiver
force-pushed
the
custom_messages
branch
2 times, most recently
from
df6f8d7 to
e0de8dc
Compare
BugDiver
force-pushed
the
custom_messages
branch
from
e0de8dc to
e8c4206
Compare
No description provided.