Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple packages to be defined with package_to_scan env var #161

Closed
nehashri opened this issue Jun 1, 2018 · 4 comments
Closed
Assignees
Milestone

Comments

@nehashri
Copy link
Contributor

nehashri commented Jun 1, 2018

Current Behaviour
To optimize the classes scanned to find all steps, hooks etc, we have a environment variable called package_to_scan. This takes only one value right now.

Expected Behaviour
package_to_scan should take multiple values.

haroon-sheikh added a commit to haroon-sheikh/gauge-java that referenced this issue Jun 3, 2018
haroon-sheikh added a commit to haroon-sheikh/gauge-java that referenced this issue Jun 3, 2018
@zabil zabil added this to the 1.1 milestone Jun 5, 2018
nehashri pushed a commit that referenced this issue Jun 6, 2018
Adds classpath helper to remove duplication
@nehashri
Copy link
Contributor Author

nehashri commented Jun 6, 2018

should be available in nightly >= 06-06-2018

@ajoecker
Copy link
Contributor

just found this now - cannot find documentation about the variable - is there any ?

Does the variable accept packnames or also wildcards ? So would com.mydomain.* be valid and scan all subpackages of com.mydomain ?

@nehashri
Copy link
Contributor Author

@ajoecker It looks like this feature was implemented already. However there seems to be some issues related to this, they are referenced above.

The current implementation is that, package_to_scan environment variable can be specified, it can take a comma separated list of packages. If a package is specified, it should scan all its subpackages as well.
For example, package_to_scan = com.thoughtworks effectively returns URLs from the classpath containing packages starting with com.thoughtworks.
For now, we don't allow wildcards here.

@ajoecker
Copy link
Contributor

then no wildcard is needed... thx @nehashri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

7 participants