Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot is not captured on hook failure #149

Closed
Apoorva-GA opened this issue May 21, 2018 · 11 comments
Closed

Screenshot is not captured on hook failure #149

Apoorva-GA opened this issue May 21, 2018 · 11 comments
Assignees
Labels

Comments

@Apoorva-GA
Copy link
Contributor

From @sguptatw on March 29, 2018 3:6

Expected behavior
The screenshot should be displayed on failure

Actual behavior
Screenshot is not displayed on failure

Steps to replicate

  • Create a gauge-js project
  • Add a new step
  • Give the default implementation
  • Run the specs gauge run specs
  • Open the html-report

No screenshot is displayed

Version

Gauge version: 0.9.8.nightly-2018-03-28
Commit Hash: 66fc822

Plugins
-------
html-report (4.0.4.nightly-2018-03-28)
js (2.2.0.nightly-2018-03-28)

Copied from original issue: getgauge/html-report#172

@Apoorva-GA
Copy link
Contributor Author

From @sguptatw on March 29, 2018 3:12

The screenshot version is screenshot (0.0.1)

@Apoorva-GA
Copy link
Contributor Author

From @sguptatw on March 29, 2018 4:58

There are 2 issues in this

@Apoorva-GA
Copy link
Contributor Author

I think the given steps to replicate and the next comment which says When there is an error in hooks, screenshot is not displayed are two different things.

Whats the actual issue here?

@Apoorva-GA
Copy link
Contributor Author

From @sguptatw on May 21, 2018 8:14

The actual issue is When there is an error in the hooks, screenshot is not displayed

Steps to replicate

  • Create a gauge-js project
  • Add a new hook implementation
  • Give the implementation with error
  • Run the specs gauge run specs
  • Open the html-report

@Apoorva-GA
Copy link
Contributor Author

Fix should be available in gauge-js Nightly >= 21/05/18

@sswaroopgupta
Copy link
Contributor

Expected behavior
Screenshot should be available on failure in hook

Actual behavior
Screenshot is not available in hook

Steps to replicate

screenshot_on_failure = true

  • run the specs gauge run
  • Open the HTML-report

The screenshot is not available for hook failure

Version

Gauge version: 1.0.4.nightly-2018-11-12
Commit Hash: a60ffbf

Plugins
-------
js (2.3.4.nightly-2018-11-13)

@sswaroopgupta sswaroopgupta reopened this Nov 19, 2018
@sswaroopgupta sswaroopgupta changed the title Screenshot is not captured on failure Screenshot is not captured on hook failure Nov 19, 2018
@shubhamsc shubhamsc assigned shubhamsc and unassigned Apoorva-GA Nov 29, 2018
@gaugebot
Copy link

gaugebot bot commented Nov 29, 2018

The fix should be available in gauge nightly >= 29-11-2018

@sswaroopgupta
Copy link
Contributor

The issue is still replicable on version

Gauge version: 1.0.4.nightly-2018-11-26
Commit Hash: f6cb60c

Plugins
-------
js (2.3.4.nightly-2018-11-29)

Steps to replicate

screenshot_on_failure = true

  • run the specs gauge run
  • Open the HTML-report

The screenshot is not available for hook failure

@sswaroopgupta
Copy link
Contributor

Blocker - The latest available gauge nightly is Gauge/Nightly/1.0.4.nightly-2018-11-26 where as required nightly is >= 29-11-2018

@sriv
Copy link
Member

sriv commented Nov 30, 2018

The build infrastructure (https://build.gauge.org) has some issues at the moment. Looking into it.

@gaugebot
Copy link

gaugebot bot commented Dec 4, 2018

The fix should be available in gauge nightly >= 3-12-2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants