Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pure javascript grpc implementation as default #317

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Use pure javascript grpc implementation as default #317

merged 1 commit into from
Mar 27, 2020

Conversation

zabil
Copy link
Member

@zabil zabil commented Mar 26, 2020 •
edited
Loading

Fixes #316

Use pure javascript grpc client so that it does not
depend on an c binaries especially when switching
node versions

@zabil
Use pure javascript grpc implementation as default
585d706 
Use pure javascript grpc client so that it does not
depend on an c binaries especially when switching
node versions
@gaugebot gaugebot bot added the cla-signed label Mar 26, 2020
@gaugebot gaugebot bot requested a review from sriv March 26, 2020 14:58
@sriv sriv merged commit 58d7a7f into getgauge:master Mar 27, 2020
@zabil zabil added the feature label Apr 2, 2020
@zabil zabil deleted the purejsgrpc branch April 21, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriv sriv sriv approved these changes

Assignees
No one assigned
Labels
cla-signed feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch gauge-js to pure javascript grpc
2 participants
@zabil @sriv