-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep modname starts with ./
#485
Conversation
@yuqianma thanks for the fix. Could you please sign the commits? See https://github.com/getgauge/gauge-js/pull/485/checks?check_run_id=2716234222 for instructions. |
Signed-off-by: Yuqian Ma <mayq0422@gmail.com>
@sriv done ? |
Signed-off-by: Yuqian Ma <mayq0422@gmail.com>
CI passed, ready to merge? |
@yuqianma Thank you for contributing to gauge-js. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Thanks @yuqianma - can you please bump the version to |
Signed-off-by: Yuqian Ma <mayq0422@gmail.com>
@sriv Just called |
Yes, this looks fine. Will merge post runs pass. |
Bug:
require('./constants')
resulted inrequire('constants')
.