Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep modname starts with ./ #485

Merged
merged 3 commits into from
Jun 2, 2021
Merged

fix: keep modname starts with ./ #485

merged 3 commits into from
Jun 2, 2021

Conversation

yuqianma
Copy link
Contributor

@yuqianma yuqianma commented Jun 1, 2021

Bug: require('./constants') resulted in require('constants').

@sriv
Copy link
Member

sriv commented Jun 1, 2021

@yuqianma thanks for the fix. Could you please sign the commits? See https://github.com/getgauge/gauge-js/pull/485/checks?check_run_id=2716234222 for instructions.

Signed-off-by: Yuqian Ma <mayq0422@gmail.com>
@yuqianma
Copy link
Contributor Author

yuqianma commented Jun 1, 2021

@sriv done ?

Signed-off-by: Yuqian Ma <mayq0422@gmail.com>
@yuqianma
Copy link
Contributor Author

yuqianma commented Jun 2, 2021

CI passed, ready to merge?

@sriv sriv added the ReleaseCandidate If a PR is tagged with this label, after merging it will be released label Jun 2, 2021
@gaugebot
Copy link

gaugebot bot commented Jun 2, 2021

@yuqianma Thank you for contributing to gauge-js. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@sriv
Copy link
Member

sriv commented Jun 2, 2021

Thanks @yuqianma - can you please bump the version to 2.3.17 - this will allow us to release gauge-js post merging this PR.

Signed-off-by: Yuqian Ma <mayq0422@gmail.com>
@yuqianma
Copy link
Contributor Author

yuqianma commented Jun 2, 2021

@sriv Just called python update_version.py. Am I right?

@sriv
Copy link
Member

sriv commented Jun 2, 2021

Yes, this looks fine. Will merge post runs pass.

@sriv sriv merged commit de91678 into getgauge:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseCandidate If a PR is tagged with this label, after merging it will be released
Development

Successfully merging this pull request may close these issues.

2 participants