-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for a simplified data store API #93
Comments
Hi @surajbarkale - thank you for the suggestion. This looks neat. Would you like to send us a Pull Request? |
I shall try to create one |
BugDiver
pushed a commit
that referenced
this issue
Jul 19, 2018
* Add dictionary based data store * Allow attribute acces to data store * Revert changes to skel to submit as seperate PR * Add deprecation warnings for existing data store API
This issue still needs testing. |
The fix Should be available in nightly >= 19 July 2018 |
Documentation should be updated with the recommended usage. |
The documentation is already updated. Refer getgauge/docs.gauge.org#85 |
ghost
removed
the
ready for QA
label
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The current data store API seems to be inspired by Java and does not feel very pythonic. A simple
dict
access would better suit python code.Implementation in getgauge/python.py can be:
It can be used in step as follows:
This API can also be made backwards compatible through existing
DataStoreFactory
interface.The text was updated successfully, but these errors were encountered: