Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steps file are opened with read+write permissions. #97

Closed
aasim opened this issue Jul 30, 2018 · 2 comments
Closed

steps file are opened with read+write permissions. #97

aasim opened this issue Jul 30, 2018 · 2 comments

Comments

@aasim
Copy link

aasim commented Jul 30, 2018

Description

The load_files function in static_loader.py reads python files using the "r+" access mode. This should be just "r" since the file is not written into.

Steps to reproduce

  1. Mount the steps_impl_dir as a readonly directory with all python files with read-only permissions for the runAs user.
  2. Run gauge run specs/
  3. The command fails as it is unable to read the steps_impl_dir correctly.

Information that will help us debug

  • Gauge version: 1.0.0
  • Gauge Python plugin version: 0.3.3
  • Python version: 3.6
  • getgauge package version, run pip3 show getgauge to get it: 0.3.3
  • OS information: library/python:3.6 docker (Ubuntu)

Plugins

html-report (4.0.4)
json-report (0.2.2)
python (0.3.3)
screenshot (0.0.1)

BugDiver pushed a commit that referenced this issue Aug 1, 2018
@BugDiver
Copy link
Member

BugDiver commented Aug 1, 2018

The fix should be available in nightly >= 01-08-2018.

@sswaroopgupta
Copy link
Contributor

Verified in

Gauge version: 1.0.1.nightly-2018-07-31
Commit Hash: 4ae7c9a

Plugins
-------
python (0.3.4.nightly-2018-07-25)

@ghost ghost removed the ready for QA label Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants