Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY,MAINT: Style of coding enhanced #108

Merged
merged 7 commits into from
Sep 4, 2018
Merged

Conversation

surevs
Copy link
Contributor

@surevs surevs commented Aug 30, 2018

Following are the specific and detail changes which are implemented as a part of this pull request:

  • possible PEP8 fixes have been done which does not affect the functionality of code
  • Futures have been added to requirements to ensure things work correct as expected as python 2.7 core does not include it at requirements.txt:11
  • Good to have grpc as part of requirements - requirements.txt:12
  • Imported specific ThreadPoolExecutor as it is only used in start.py
  • Updated the try import of collections to reflect based on python version at getgauge\python.py:6

@sriv sriv added the ready label Aug 30, 2018
@surevs
Copy link
Contributor Author

surevs commented Aug 30, 2018

Thanks a lot @sriv , Will await for your review comments.

@surevs
Copy link
Contributor Author

surevs commented Aug 30, 2018

  • grpc has been removed from the requirements as grpcio and grpcio-tools already exists

@surevs
Copy link
Contributor Author

surevs commented Sep 3, 2018

@gaugebot recheck

@surevs
Copy link
Contributor Author

surevs commented Sep 4, 2018

@sriv please advise in case of any changes to be done .

@surevs
Copy link
Contributor Author

surevs commented Sep 4, 2018

@gaugebot recheck

@sriv
Copy link
Member

sriv commented Sep 4, 2018

@BugDiver - would you mind taking a look at this please? thanks.

@getgauge getgauge deleted a comment from gaugebot bot Sep 4, 2018
@getgauge getgauge deleted a comment from gaugebot bot Sep 4, 2018
@getgauge getgauge deleted a comment from gaugebot bot Sep 4, 2018
@getgauge getgauge deleted a comment from gaugebot bot Sep 4, 2018
@getgauge getgauge deleted a comment from gaugebot bot Sep 4, 2018
@BugDiver
Copy link
Member

BugDiver commented Sep 4, 2018

@surevs Sorry for the delay. Looks like BOT had some issues validating your PR.
I checked the records manually but did not find you.
Can you please sign the CLA at https://gauge-bot.herokuapp.com/cla/
You can validate your self by browsing at https://gauge-bot.herokuapp.com/contributor?checkContributor=YOUR_USER_NAME

@getgauge getgauge deleted a comment from surevs Sep 4, 2018
@getgauge getgauge deleted a comment from sriv Sep 4, 2018
@getgauge getgauge deleted a comment from sriv Sep 4, 2018
@surevs
Copy link
Contributor Author

surevs commented Sep 4, 2018

@gaugebot recheck the pull request.

@gaugebot
Copy link

gaugebot bot commented Sep 4, 2018

This PR has been verified. The gauge team will be looking into this soon.

/cc @getgauge/core

@gaugebot gaugebot bot added the cla-signed label Sep 4, 2018
@BugDiver BugDiver merged commit abbc0c2 into getgauge:master Sep 4, 2018
@BugDiver BugDiver removed the ready label Sep 4, 2018
@surevs
Copy link
Contributor Author

surevs commented Sep 4, 2018

thank you @BugDiver !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants