Fix pip executing on every run #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version check used `is not`operator. Since `is not` checks if the instances are same and does not compare strings, pip was always invoked whenever `gauge run` is executed. This patch changes `is not` to `!=` which correctly compares strings. A check is added to properly report error when plugin is not installed. The `subprocess.check_output` function is used as it will detect subprocess failures and raise exception.
|
This is an annoyance in docker images where pip is executed on every run. The existing code did not check for pip failures so I could execute tests. |
Apoorva-GA
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version check used
is notoperator. Sinceis notchecks if the instances are same and does not compare strings, pip was always invoked whenevergauge runis executed.This patch changes
is notto!=which correctly compares strings. A check is added to properly report error when plugin is not installed.Apart from this fix, the
subprocess.check_outputfunction is used as it will detect subprocess failures and properly raise exception.