Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The errors of refactoring should be indicated #122

Closed
sswaroopgupta opened this issue Feb 5, 2018 · 5 comments
Closed

The errors of refactoring should be indicated #122

sswaroopgupta opened this issue Feb 5, 2018 · 5 comments
Assignees
Labels

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Feb 5, 2018

Actual behavior
No result is displayed on the step text

Steps to replicate

  • In a gauge-js project
  • Refactor Vowels in English language are "aeiou" to an empty step. This should display the reason why refactoring failed clearly.
    Currently the output pane shows the error
Request textDocument/rename failed.
  Message: Refactoring failed due to errors:
:2 Step should not be blank => ''
  Code: 0 
  • Another example is when { is used in the step
Request textDocument/rename failed.
  Message: Refactoring failed due to errors:
:2 '{' is a reserved character and should be escaped => '"aeiou" Vowels in English "ddd" {}'
  Code: 0 
  • Another example
Request textDocument/rename failed.
  Message: refactoring failed due to parse errors
  Code: 0 

However the IDE gives No result on the step.

Version

Gauge version: 0.9.8.nightly-2018-01-30
Commit Hash: 2ed02d8

Plugins
-------
js (2.1.1.nightly-2018-01-16)

Bug on story #81

@nehashri
Copy link
Contributor

Fix should be available in nightly >= 15-2-18

@sswaroopgupta
Copy link
Contributor Author

Blocked 'cause of getgauge/gauge#943

@sswaroopgupta
Copy link
Contributor Author

Question

  • How should multiple errors be handled?
    Example: One/more concept file can have a parse errors 'cause if which user cannot refactor.

@nehashri
Copy link
Contributor

Showing multiple errors in the error popup may not be possible. VSCode's error pop up doesn't render properly for large/multiline texts. Right now, the errors are show with a tab spacing between them.

If needed, we can add a button to open the output console where more information about the errors are indicated.

@BugDiver
Copy link
Member

Please verify the issue and update.

Blocked 'cause of getgauge/gauge#943

This issue has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants