Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show recommended settings in command pallete should have the Ignore always option #310

Closed
sswaroopgupta opened this issue Nov 29, 2018 · 4 comments
Closed

Show recommended settings in command pallete should have the Ignore always option #310

sswaroopgupta opened this issue Nov 29, 2018 · 4 comments
Assignees
@Apoorva-GA

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Nov 29, 2018 •
edited by Apoorva-GA
Loading

Expected behavior
Show recommended settings in command pallete should have the Ignore always option

Actual behavior
User is able to select Ignore Always on the pop-up suggesting Gauge-recommendations. However the command pallete does not reflect this option

Steps to replicate

  • Open a Gauge project
  • Open the command pallete
  • Open Gauge configuration

Show Recommended Settings is still a boolean

Even in the User settings this reflects as a boolean. How can I differentiate between Ignore and Ignore Always?
showrecommendedsettings

Version

Gauge VSCode - gauge-0.0.8.nightly-2018-11-27

Blocks #302 #298
@Apoorva-GA Apoorva-GA self-assigned this Dec 10, 2018
Apoorva-GA added a commit that referenced this issue Dec 12, 2018
@Apoorva-GA
Adding options to show recommended settings from command pallete #310
e0989f9
@gaugebot
Copy link

gaugebot bot commented Dec 12, 2018

The fix should be available in nightly >= 12-12-2018

@sswaroopgupta
Copy link
Contributor Author

The current value is getting defaulted to the first value. But that is not the user selection. To solve this we should have the first option as Select. Which indicates that the user has not chosen the recommendedSettings yet.

@Apoorva-GA Apoorva-GA removed their assignment Dec 18, 2018
@Apoorva-GA Apoorva-GA self-assigned this Dec 19, 2018
Apoorva-GA added a commit that referenced this issue Dec 19, 2018
@Apoorva-GA
Adding Not Selected option to the config #310
9f0d636
@gaugebot
Copy link

gaugebot bot commented Dec 19, 2018

The fix should be available in nightly >= 19-12-2018

Apoorva-GA added a commit that referenced this issue Dec 20, 2018
@Apoorva-GA
Changing the ignore to remaind me later and removing the default value …
355dda5 
…#310
@Apoorva-GA
Copy link
Contributor

  • Renamed Ignore to Remind me later, and its the default value.
  • Renamed Ignore Always to Ignore.
  • Apply & Reload remains the same.

The fix should be available in nightly >= 20-12-2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Apoorva-GA Apoorva-GA

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sswaroopgupta @Apoorva-GA