Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply and reload in the command palette should apply the recommended settings #318

Closed
sswaroopgupta opened this issue Dec 24, 2018 · 6 comments
Closed

Apply and reload in the command palette should apply the recommended settings #318

sswaroopgupta opened this issue Dec 24, 2018 · 6 comments
Assignees
@Apoorva-GA

Comments

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Dec 24, 2018 •
edited
Loading

Expected behavior
Apply and reload in the command palette should apply the recommended settings

Actual behavior
It does not apply the recommended settings

Steps to replicate

  • Open the command palette
  • Change the Recommended settings to ignore
  • Change the Auto Save Delay to 1000
  • Reload the project
  • Now change it Apply and reload.
  • Reload the project

The selection is Apply and reload but the value of Auto Save is not changed to the recommended setting

Version

gauge-0.0.8.nightly-2018-12-20

Blocks #302
@Apoorva-GA Apoorva-GA self-assigned this Jan 2, 2019
Apoorva-GA added a commit that referenced this issue Jan 2, 2019
@Apoorva-GA
Apply and reload should apply recomended setting when set in congig a…
c081854 
…nd reload #318
@gaugebot
Copy link

gaugebot bot commented Jan 2, 2019

The fix should be available in nightly >= 2-1-2019

@sswaroopgupta
Copy link
Contributor Author

The required nightly is not available. The latest available nightly is 0.0.8.nightly-2018-12-27.

@Apoorva-GA
Copy link
Contributor

Nightly gets triggered at IST 1PM every day.

@sswaroopgupta
Copy link
Contributor Author

Question
If the setting is Apply & Reload, the user changes the recommended settings to something else. Now what should be the behavior on reload?

@Apoorva-GA
Copy link
Contributor

It should apply the recommended settings.

@sswaroopgupta
Copy link
Contributor Author

Verified with version

gauge-0.0.8.nightly-2019-01-03.vsix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Apoorva-GA Apoorva-GA

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sswaroopgupta @Apoorva-GA