Adding command to create a gauge project from vscode #211 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
sriv
requested changes
Apr 3, 2018
src/init/projectInit.ts
Outdated
| commands.executeCommand(VSCodeCommands.OpenFolder, uri, !!workspace.workspaceFolders); | ||
| } | ||
|
|
||
| cancle(message: string | Buffer) { |
| return new Promise(async (res, rej) => { | ||
| let ph = new ProgressHandler(p, res, rej); | ||
| if (this.isGaugeInstalled) await this.createFromCommandLine(template, projectFolder, ph); | ||
| else await this.createFromTemplate(template, projectFolder, ph); |
There was a problem hiding this comment.
lets not mix async and promises. instead of await, can we do a .then and .catch?
src/init/projectInit.ts
Outdated
|
|
||
| import { VSCodeCommands, GaugeCommands, GaugeVSCodeCommands, GAUGE_TEMPLATE_URL } from "../constants"; | ||
| import { FileListItem } from '../types/fileListItem'; | ||
| import { spawnSync, execSync, spawn } from 'child_process'; |
src/init/projectInit.ts
Outdated
| let options: any = { prompt: "Enter a name for your new project", placeHolder: "gauge-tests" }; | ||
| const name = await window.showInputBox(); | ||
| if (!name) return; | ||
| options = { canSelectFolders: true, openLabel: "Select a folder to create the project in" }; |
There was a problem hiding this comment.
use canSelectMany to enforce a single folder selection. Ref: here
BugDiver
force-pushed
the
create-project
branch
from
725b4d3 to
358ee78
Compare
sriv
approved these changes
Apr 11, 2018
added 2 commits
April 12, 2018 11:06
BugDiver
force-pushed
the
create-project
branch
from
358ee78 to
6fb63f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.