Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Link to release notes whenever gauge plugin updates #30 #59

Merged
merged 9 commits into from
Nov 28, 2017

Conversation

riju91
Copy link
Contributor

@riju91 riju91 commented Nov 27, 2017

  • Whenever gauge vscode plugin version changes(autoupdate) show a message to notify that and link to the release notes.

@ghost ghost assigned riju91 Nov 27, 2017
@ghost ghost added the in progress label Nov 27, 2017
@cla-bot cla-bot bot added the cla-signed label Nov 27, 2017
src/extension.ts Outdated
const gaugeVsCodePreviousVersion = context.globalState.get<string>(GAUGE_VSCODE_VERSION);

// First time installation
if (gaugeVsCodePreviousVersion === undefined) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add the current gaugeVsCodeVersion to globalState for first time installation.

@nehashri
Copy link
Contributor

Tests can be added.

@ghost ghost assigned nehashri Nov 28, 2017
@nehashri nehashri merged commit a6e344d into master Nov 28, 2017
@ghost ghost removed the in progress label Nov 28, 2017
@nehashri nehashri deleted the linkReleaseNotes branch November 28, 2017 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants