Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Mac ARM64 Chromium #2668

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Add support for Mac ARM64 Chromium #2668

merged 2 commits into from
Dec 8, 2022

Conversation

marques-work
Copy link
Contributor

@zabil quick review when you get a moment? I've tested this on my M1 MBP and npm test passes.

Also verified the binary image is indeed ARM64 (in case your machine is x86_64):

$ file .local-chromium/mac_arm-1075999/chrome-mac/Chromium.app/Contents/MacOS/Chromium
.local-chromium/mac_arm-1075999/chrome-mac/Chromium.app/Contents/MacOS/Chromium: Mach-O 64-bit executable arm64

zabil
zabil approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@zabil zabil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @marques-work

@zabil zabil merged commit 59eefb8 into getgauge:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zabil zabil zabil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marques-work @zabil