Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Fullscreen --> no scrollbar anymore! #1077

Closed
axel-rank opened this issue Apr 20, 2017 · 10 comments
Closed

Editor Fullscreen --> no scrollbar anymore! #1077

axel-rank opened this issue Apr 20, 2017 · 10 comments
Labels
fixed

Comments

@axel-rank
Copy link

axel-rank commented Apr 20, 2017 •
edited
Loading

Latest Grav (1.2.3) Latest Admin (1.4.1):
Going to fullscreen view --> there's no scrollbar. Can't see/edit full article/content anymore!
Firefox 53.0
@OleVik
Copy link
Contributor

OleVik commented Apr 20, 2017

Are there any errors in the Console of your DevTools? (Press F12 or ctrl+shift+i).

@axel-rank
Copy link
Author

admin 1.3.3:
admin_1 3 3

admin 1.4.1:
admin_1 4 1

@OleVik
Copy link
Contributor

OleVik commented Apr 20, 2017

Specifically, what (if any) errors are thrown into the "Console/Konsole"-tab of the inspector after a refresh?

@axel-rank
Copy link
Author

axel-rank commented Apr 20, 2017 •
edited
Loading

If you refresh when you're in fullscreen view the editor goes back to normal view.
I can see no errors in Konsole Tab.
Another issue maybe related to the scrollbar issue: add function doesn't show options in fullscreen.

normal view:
editor1

fullscreen:
editor2

@OleVik
Copy link
Contributor

OleVik commented Apr 20, 2017

Are there any errors if you: Open the page, open developer tools, refresh, then open fullscreen? If necessary, subsequently close fullscreen then view the Console/Konsole and note any errors there.

@axel-rank
Copy link
Author

Yes, here it is:

message

@OleVik
Copy link
Contributor

OleVik commented Apr 20, 2017

Could you copy that as text or translate it? My German is not up to scratch, but it has something to do with Mozilla's ScrollLinkedEffects (more details).

@axel-rank
Copy link
Author

editor

@rhukster
Copy link
Member

Looks like a z-index issue for that dropdown. Should be fixable.

rhukster added a commit that referenced this issue Apr 20, 2017
@rhukster
Fix for missing scrollbar when in full-size editor and add dropdown #…
61334fa 
…1077
@rhukster
Copy link
Member

Fixed the dropdown and the scrollbar.

2017-04-20 at 5 12 pm

@rhukster rhukster added the fixed label Apr 20, 2017
ricardo118 added a commit to ricardo118/grav-aviary-plugin that referenced this issue Apr 26, 2017
@ricardo118
Updated Grav Admin to v1.4.2
0e8a624 
1. [](#new)
    * Added a new `Content Padding` option to tighten up UI padding space (default `true`)
1. [](#bugfix)
    * Added back `Admin::initTheme()` relying on Grav fix [#1069](getgrav/grav-plugin-admin#1069) as it conflicts ith Gantry5
    * Fix for missing scrollbar when in full-size editor for Firefox [#1077](getgrav/grav-plugin-admin#1077)
    * Fix for overlay of Add-Page button in full-size editor [#1077](getgrav/grav-plugin-admin#1077)
    * Better fix for session-based parent overriding root page parents [#1078](getgrav/grav-plugin-admin#1078)
    * Allow support for `Pages::getList()` with `show_modular` option [#1080](getgrav/grav-plugin-admin#1080)
    * Added `[tmp,user]` ignores for direct install of Grav [grav#1447](getgrav/grav#1447)
@axel-rank axel-rank mentioned this issue Apr 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OleVik @rhukster @axel-rank