Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer attach pages to non-routable pages in v1.8.16 #1599

Closed
lucaswillering opened this issue Jan 26, 2019 · 4 comments
Closed

Can no longer attach pages to non-routable pages in v1.8.16 #1599

lucaswillering opened this issue Jan 26, 2019 · 4 comments
Labels

Comments

@lucaswillering
Copy link

It seems that in v1.8.16 of the admin plugin it is no longer possible to attach pages to a non-routable but visible, published page.

I have a site structure like this:

  • Main page (routable, visible, published)
    -- Section (non-routbale, visible, published)
    --- Child page 1 (routabe, visible, published)
    --- Child page 2 (routable, visible, published)

When I create a new page, the dropdown for 'Parent page' only shows the Main page. When I edit 'Child page 1' the 'Parent page' dropdown indicates that the page will be attached to the root when I save it.

Is this intended functionality?

@lucaswillering lucaswillering changed the title Can no longer attached pages to non-routable pages in v1.8.16 Can no longer attach pages to non-routable pages in v1.8.16 Jan 26, 2019
@rhukster
Copy link
Member

Guessing this PR is the cause: ffe08b0

@rhukster
Copy link
Member

It's an option in the admin plugin config, but seems like it should default to the previous behavior, but allow you to disable it.

@lucaswillering
Copy link
Author

Thanks Andy, that seems to be the cause indeed. While the admin panel does show 'Modular parents - enabled' after updating, it doesn't default to the previous behavior. Hitting save in the admin panel settings (without changing anything) solved the problem I was experiencing.

@rhukster
Copy link
Member

Great I’ll fix that for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants