Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html entities are not rendered properly #1990

Closed
renards opened this issue Dec 6, 2020 · 1 comment
Closed

Html entities are not rendered properly #1990

renards opened this issue Dec 6, 2020 · 1 comment

Comments

@renards
Copy link

renards commented Dec 6, 2020

Hello,
today I updated my Admin Panel to version 1.9.18. Now in the Pages section under the Advanced Tab and there in the Settings section, the HTML entities in the Parent-Page-List are no longer rendered properly, as you can see on the screenshot :

grav_admin_html_entities

I think this is caused by the following commit : commit d01c959

Therefore I changed line 13 in public/user/plugins/admin/themes/grav/templates/forms/fields/pages/pages.html.twig from
<option {% if page_route == value or (field.multiple and page_route in value) %}selected="selected"{% endif %} value="{{ page_route }}">{{ option }}</option>
to
<option {% if page_route == value or (field.multiple and page_route in value) %}selected="selected"{% endif %} value="{{ page_route }}">{{ option|striptags|raw }}</option>
in my local installation.

It's no big issue, but for some editors it might be a bit confusing.

My environment :

  • Grav version : 1.6.30
  • Admin Panel : 1.9.18
  • PHP version : 7.4.13
  • Linux server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants