Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Browsing in Safari doesn't allow localStorage and throws JS errors #527

Closed
Quy opened this issue Apr 28, 2016 · 14 comments
Closed
Assignees
Labels

Comments

@Quy
Copy link

Quy commented Apr 28, 2016

For example, under System>Content, Long display date format is cut off and you can't scroll pass this point to see the other options.

@rhukster rhukster added the ui label Apr 28, 2016
@rhukster
Copy link
Member

Thanks, we'll have a look at this.

@rhukster
Copy link
Member

What version of the admin are you on?

We did some major rework of mobile support in the 1.1.X beta of the Admin and this works on iOS, I just tested on my phone, works fine in Safari and Chrome.

@Quy
Copy link
Author

Quy commented Apr 28, 2016

v1.1.0-beta.2 test release. Downloaded the entire package from here: https://www.getgrav.org/downloads

@rhukster
Copy link
Member

What browser? I can't replicate this.. Working fine on my iphone and on the iOS Simulator for ipad.

@rhukster
Copy link
Member

@Quy
Copy link
Author

Quy commented Apr 28, 2016

Not working with Safari on iOS 9.3.1 (iPad)
Working on iPhone 6s but not iPhone 4s

@Quy
Copy link
Author

Quy commented Apr 28, 2016

I connected the iPad to a MacBook Pro and in Safari>Develop, here are errors that may be related to the issue:
QuotaExceededError: DOM Exception 22: An attempt was made to add something to storage that exceeded the quota..setItem - admin.min.js:4:21701
Failed to load resource: the server responded with a status of 404 (Not Found)...user/plugins/admin/themes/grav/js/vendor.min.js.map
Failed to load resource: the server responded with a status of 404 (Not Found)...user/plugins/admin/themes/grav/js/admin.min.js.map

@rhukster
Copy link
Member

Well that's interesting! I'll hand this over to our resident JS expert to have a look at.

@rhukster
Copy link
Member

Are you using private browsing? i googled, and seems like that might be an issue. The admin does use local storage in places to store info and states.

@rhukster
Copy link
Member

Yup, i can recreate with private browsing. I think this limits a lot of functionality for storing state locally, so this is simply not going to work with the admin. Just use regular browsing mode and it should work fine.

@Quy
Copy link
Author

Quy commented Apr 28, 2016

Confirmed that private browsing is the culprit. Thank you!

@w00fz
Copy link
Member

w00fz commented Apr 28, 2016

Reopening and editing the title.

Thanks.

@w00fz w00fz reopened this Apr 28, 2016
@w00fz w00fz added bug and removed ui labels Apr 28, 2016
@w00fz w00fz changed the title Page not scrollable on iPad Private Browsing in Safari doesn't allow localStorage and throws JS errors Apr 28, 2016
@rhukster
Copy link
Member

Closing as we can't really fix this.

w00fz added a commit that referenced this issue May 3, 2016
@w00fz
Copy link
Member

w00fz commented May 3, 2016

I actually fixed this now, so stay tuned for next beta.

Only note of consideration is that you will still see an error in the console that is caused by debugbar of which we really don't have control over. However I did test and admin still works fine, quite likely you won't only be able to use the debug bar.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants