Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages are not visible by default after removing all existing pages. #551

Closed
RomainFallet opened this issue May 3, 2016 · 7 comments
Closed
Labels

Comments

@RomainFallet
Copy link
Contributor

Pages are not visible by default after removing all existing pages. It's a bit weird, even after forcing it to be visible in the Advanced tab.

Here is the video that shows the thing, I am starting from a fresh Grav installation :
https://www.youtube.com/watch?v=HzWS84FlwfY

@rhukster
Copy link
Member

rhukster commented May 3, 2016

I 'think' this is related to the fact that you deleted the 'homepage', and then didn't add it back. Perhaps after creating your test page, and then going to the system config, and setting your homepage to this, it would be visible. Could you try that?

@RomainFallet
Copy link
Contributor Author

RomainFallet commented May 3, 2016

When I go to the system config just after creating the test page, the "Home page" setting is already set with the test page. I tried to resave the config, but it does not change the visibility.
screenshot at mai 03 17-00-50

@rhukster
Copy link
Member

rhukster commented May 3, 2016

What do the files actually look like after you recreate them? Also when you create that new 'test' page, try setting visible to Yes rather than leaving it on Auto (in the new page modal)

@RomainFallet
Copy link
Contributor Author

The page looks good, in admin panel and in the front (see screenshot 1 and 2), as well as my files system and in the page file (see screenshot 3 and 4).

I deleted the test page to recreate it with the visible setting set to Yes. But the page is still marked as "Non-visible" (see screenshot 5).

screenshot at mai 03 17-20-38
screenshot at mai 03 17-20-49
capture d ecran 2016-05-03 a 17 26 43
capture d ecran 2016-05-03 a 17 27 01
screenshot at mai 03 17-21-36

@rhukster
Copy link
Member

rhukster commented May 3, 2016

Ok, i've tested this, following your steps, and the page does show as visible for me if i override the visibility option, and also if i enable numeric prefix (which is the files way of doing things).

The only minor issue I see is the modal option of visible didn't set it to visible on creation. This i'll take a look at.

@rhukster rhukster added bug and removed question labels May 3, 2016
@RomainFallet
Copy link
Contributor Author

RomainFallet commented May 3, 2016

For me the biggest issue is that all new pages created on root after this are set as "non-visible" by default. Users should not have to check "visible" button for each new pages. The auto setting still should, as well as the visible setting, set pages to "visible" on creation.

@rhukster
Copy link
Member

rhukster commented May 3, 2016

Should be fixed in develop

@rhukster rhukster closed this as completed May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants