Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to delete responsive @2x and @3x images in Page Media #952

Closed
vladzhigulsky opened this issue Feb 1, 2017 · 3 comments
Closed

Unable to delete responsive @2x and @3x images in Page Media #952

vladzhigulsky opened this issue Feb 1, 2017 · 3 comments
Assignees
@flaviocopes

Comments

@vladzhigulsky
Copy link

Please note the issue with Page Media and responsive images (@2x or @3x) described in #111 is still present. Error File not found: image.jpg while trying to delete the file.

It also affects filepicker field with preview_images enabled.

Steps:
Uploaded image@3x.jpg and tried to select it via filepicker

Result:
The preview thumbnail is broken because it's not reading @3x
@flaviocopes flaviocopes self-assigned this Feb 1, 2017
@fredrikekelund
Copy link
Contributor

I tried to address a similar issue with #814. But I believe the code will only try to remove image alternatives if it can find the "base medium", ie. the image without any @Nx

flaviocopes added a commit that referenced this issue Feb 6, 2017
@flaviocopes
Fix removing responsive image from page media re #111 re #952
b775ff9
@vladzhigulsky
Copy link
Author

Thanks a lot!

@flaviocopes
Copy link
Contributor

Thanks for reporting 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviocopes flaviocopes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredrikekelund @flaviocopes @vladzhigulsky