Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilevel field #1135

Merged
merged 42 commits into from
Jun 27, 2017
Merged

Multilevel field #1135

merged 42 commits into from
Jun 27, 2017

Conversation

flaviocopes
Copy link
Contributor

@flaviocopes flaviocopes commented Jun 14, 2017 •
edited
Loading

k6bxf65wgq

Example definition in blueprint:

    content:
        type: multilevel
        label: Multi Level
        style: vertical
        validate:
          type: array

For the benefit of simplicity, currently:

  • parent items cannot be edited (or all the child structure changes) (removed limitation in e427bac)
  • you can only add siblings as last in the list

flaviocopes added 19 commits June 13, 2017 11:26
@flaviocopes
Reading values / saving values working
25cf1ee
@flaviocopes
Adding new siblings / removing item
1478f03
@flaviocopes
Going on
daa25b1
@flaviocopes
Hide + on all elements to only add to the last on pageload
2d02547
@flaviocopes
Only allow adding at the bottom of a list, for simplicity. Restore bu…
a4bf75a 
…ttons when the list changes
@flaviocopes
Refactor a little bit
6dc208e
@flaviocopes
Disable changing a parent name without dropping children first (simpl…
7c38a6c 
…ify edge cases)
@flaviocopes
Drop circle+ buttons if already has children
187d066
@flaviocopes
Fix
6821bb3
@flaviocopes
Fix for top level items
7482389
@flaviocopes
Fill name when adding children
13bc8c6
@flaviocopes
Fix interference from array js
e1584ff
@flaviocopes
Fix scope issue
45def6f
@flaviocopes
Allow multiple fields on same page
3984892
@flaviocopes
Fix closing div if
fa3e5e9
@flaviocopes
Fix for nested array structure rendering
1d8b001 
Example that was breaking the layout:

```
content6:
  items:
    - '@eeeeee':
         category: test
    - '@self.children'
    - '@taxonomy':
         category: [blog, featured]
```
@flaviocopes
Correctly name with multiple siblings setting parent_key, use another…
6cf8694 
… variable name to prevent issues
@flaviocopes
Correctly define key on non-iterable first level childrens
58acbd4
@flaviocopes
Drop todo
ab7583e
@OleVik OleVik mentioned this pull request Jun 15, 2017
Closed
@flaviocopes flaviocopes merged commit ffb3097 into develop Jun 27, 2017
@flaviocopes flaviocopes changed the title Work in progress - multilevel field Multilevel field Jun 27, 2017
@rhukster rhukster deleted the feature/multilevel-field branch October 1, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaviocopes @rhukster