Fix partially cropped last line in markdown editor #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In browsers like IE, Edge and Firefox the last line of the markdown editor was cropped due to a higher padding-bottom value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In browsers like IE, Edge and Firefox the last line of the markdown editor was cropped due to a higher padding-bottom value, see #1217.
I decreased the value from
36pxto15pxand now the last line is no longer partially cropped in Firefox, IE and Edge. In Chrome now there’s slightly more padding between the last line and the bottom of the editor than before, but still looks OK in my opinion.This solution is of course not optimal because it relies on magic numbers in CSS, but I can’t think of a simple better solution.
I haven’t committed the generated CSS.