Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Latin Extended fonts #1221

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Conversation

newbthenewbd
Copy link
Contributor

The Latin Extended characters, if used, are usually used in conjunction with characters coming purely from the Latin alphabet. This is the case for the Polish language, just to name an example, and most if not all other Slavic languages using the Latin alphabet are likely affected as well. Due to that, I believe that they should be included in the downloads from Google Fonts where possible, since random substitute font appearing in the middle of a word isn't particularly fancy.

I haven't found a guideline containing the information as to whether the compiled CSS should be included, so I haven't compiled it, which seemed like the more sensible choice.

@rhukster
Copy link
Member

Can you tell me a of a language (polish) and place i can validate in the admin where this is occurring? I need this to ensure the fix is working prperly.

@newbthenewbd
Copy link
Contributor Author

Polish language (selectable in the admin panel as "Polski"), admin panel's dashboard. Very visible in the strings "Wyczyść pamięć podręczną" (Clear Cache) and "Sprawdź aktualizacje" (Check for Updates). These buttons use the font Lato, which is the very first one in the download's URL, and the fix, placed at the end of the URL, makes the text render properly, so I suppose it works fine. Upon closer look, one can see that the problem also occurs in many other places where characters unique to the Polish alphabet are used. Screenshots attached.
Wrong
Right

@rhukster rhukster merged commit 8cf7b11 into getgrav:develop Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants