Fix collapsed noncollapsible list fields #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `field.collapsed` seems to be true even in the case of collapsible fields, making noncollapsible fields collapsed by default, with no way to expand them. According to a quick test I've done, this should fix that.
|
Actually, there's a deeper issue with this, as the collapsible fields now randomly appear expanded, yet their buttons are set the other way around... At least this serves as a somewhat better issue trace than the Slack chat log 🙃 |
|
Here we go, should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
field.collapsedseems to be true even in the case of collapsible fields, making noncollapsible fields collapsed by default, with no way to expand them. According to a quick test I've done, this should fix that.