Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional for label that ends up blank for checkboxes #532

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hdwebpros
Copy link
Contributor

Without this conditional, checkboxes render a blank label

<div class="form-label"><label class="inline"></label></div>

Having the blank label screws with accessibility.

Sure, you can manually set each checkbox to display_label: false but that in itself is confusing since removes the broken label and keeps the checkbox label. Since the default checkbox no matter what creates a blank div and label, the best way around this is to just add this conditional

Without this conditional, checkboxes render a blank label
`<div class="form-label"><label class="inline"></label></div>`

Having the blank label screws with accessibility.

Sure, you can manually set each checkbox to `display_label: false` but that in itself is confusing since removes the broken label and keeps the checkbox label. Since the default checkbox no matter what creates a blank div and label, the best way around this is to just add this conditional
@NicoHood
Copy link
Contributor

Related: #442

@hughbris
Copy link
Contributor

Related: #442

And #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants