-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #1184 Fix issue with using a multiple taxonomy filter of which on…
…e had no results If there are 2+ taxonomies required but one has 0 items, it was just picking the ones corresponding to the other taxonomy, thus generating a wrong result. Adding an empty array will later make array_intersect_key generate an empty array if the operation is `and`
- Loading branch information
1 parent
678c445
commit 896fb81
Showing
2 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
896fb81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hoped you'd offer me the pull request before you did it :(
896fb81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @hughbris, I had it ready since I was testing it, figured it was quicker than asking you to make a PR. Didn't think you were willing to make a PR, will edit the changelog message to thank you, if this helps!
896fb81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to juggle a lot of testing and checking possible issues, the quicker the fix gets in, the better, before it's forgotten or I have to look again in the future and take the time replicate the problem, did not mean to harm your contribution :)