Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi language page with redirect_trailing_slash enabled #2269

Closed
all-sd opened this issue Nov 22, 2018 · 3 comments
Closed

Multi language page with redirect_trailing_slash enabled #2269

all-sd opened this issue Nov 22, 2018 · 3 comments

Comments

@all-sd
Copy link
Contributor

all-sd commented Nov 22, 2018

if redirect_trailing_slash is enabled and you are on a translated page and add a trailing slash, the redirect will redirect you to the default language version of this page

pull request #2268

@saxinte
Copy link

saxinte commented Nov 23, 2018

Yes, I can confirm the problem is happening on Grav v1.5.5.

Also unnecessary redirects happens as well and cause SEO issues.

Here's what happen (tested with a new fresh build of Grav v1.5.5 with enabled languages):
https://www.mysite.com/de/foobar/
redirects to:
https://www.mysite.com/foobar
then redirects to:
https://www.mysite.com/en/foobar

The current language is lost in the redirects (de to en) and there's an unnecessary redirect as well.
It should be:
https://www.mysite.com/de/foobar/
redirects to:
https://www.mysite.com/de/foobar

This was not happening on Grav v1.4.2 wich is the version I've updated from. But I needed it because of that fix: #2155

Thanks

@saxinte
Copy link

saxinte commented Jan 16, 2019

@rhukster Problem has been fixed with #2155 and #2268 but introduced a tiny issue:

can be tested on Grav v1.5.6 here:

Thanks

@rhukster
Copy link
Member

rhukster commented Jan 17, 2019

I think i've fixed this, but in the 1.6 branch. I don't think this ever worked frankly as we never had any version that rebuilt the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants