Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update to 1.6.5 I get 404 for ALL translated pages #2459

Closed
drnasin opened this issue Apr 17, 2019 · 3 comments
Closed

After update to 1.6.5 I get 404 for ALL translated pages #2459

drnasin opened this issue Apr 17, 2019 · 3 comments

Comments

@drnasin
Copy link
Contributor

drnasin commented Apr 17, 2019

Only default language pages are shown. After clicking on the flag to get translated version 404 is shown. Redirect default route is set to false…

seems like redirects are without the lang code in 1.6.5. hence 404....

@rhukster
Copy link
Member

Ugg I know exactly what this is. Fixed one issue and caused this. I’ll get you a temp fix shortly...

@rhukster rhukster added the bug label Apr 17, 2019
@rhukster
Copy link
Member

Line 81 of system/src/Grav/Common/Service/PagesServicesProvider.php change that if statement to:

                // Default route test and redirect
                if ($config->get('system.pages.redirect_default_route') && $page->route() !== $path) {
                    $c->redirect($url);
                }

This was the old functionality. I'm just going to roll back my fix as the other issue was pretty obscure, and this one is much more common.

@rhukster
Copy link
Member

fixed in develop also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants