CLI Update command places existing Pages folder when a Theme '_demo' folder is updated

[paulhibbitts]

As requested, this is a new issue based on a reported CLI theme update issue.

Based on several user reports, if a theme contains a "_demo" folder this content replaces the existing Pages folder (the original is copied and renamed) when a CLI update is done if the "_demo" folder has been changed. Preferably, when a theme update via CLI is done the contents of the "_demo" folder would not be copied over.

I hope the above makes things clearer, please let me know if more info would be of help.

Below is also a series of screen caps to help illustrate the issue.

Thank you very much,
Paul

Hi, @paulhibbitts . After your comments in the getgrav forum, I did my daily update routine on my servers. There was indeed a theme update. In one of the servers, I updated the theme through the Admin panel, and no pages were changed.

In another server, I used the command line interface

        bin/gpm update

Here, the update process moved the pages directory to a time-stamped new directory (pages.05-06-2019-09-00-36) and created a new pages directory with only the theme demo content.

Screenshots follow. I hope this may be useful.

Originally posted by @quartelmestre in #2225 (comment)

[paulhibbitts]

Thank you very much @rhukster !

[quartelmestre]

Thanks, @rhukster !