Avatar image deletion don't update avatar field in yaml file.

[mhlsf]

Environment :

• Linux Fedora
• PHP 7.3.12
• Grav 1.6.19
• Admin Panel 1.9.12

Also tested on window Wamp

Step to reproduce the bug :

1. Upload an image using the filepicker on the admin profile page (admin/user/youraccount)
2. Save the profile with the save button to the top right
3. Delete the image using the bin icon on the image
4. Save again

What should happen :

There should be no image on the filepicker zone

What happen :

There is a blank image with the same information as the previously upload image

What the issue :

When we delete a profile image, Admin plugin call taskRemoveFileFromBlueprint() method in adminbasecontroller.php that correctly delete the image from the user/accounts/avatar folder but don't update the avatar field in the yaml file.

I would like to provide a fix but I don't know if the yaml file should be updated in taskRemoveFileFromBlueprint() or should be done trough taskSaveUser()

I suspect it should be done in the taskSaveUser() but the data filter seem to remove the avatar field when it is empty (see Grav/Common/Data/Validation.php)

[mahagr]

Avatar cannot be deleted because of deleting it will not trigger AJAX request to delete the file. Additionally data[avatar] contains information from the old image.

[mhlsf]

Actually on deletion from admin the AJAX call is send and the file is well deleted, this is just the blueprint that isn't updated.

My guess would be to toggle $keepEmptyValues from filter function of Grav\Common\Data.

Editing method taskSaveUser() in admincontroller, line 704 as follow :

$data->filter();

to

$data->filter(False, True);

It seem to fix the issue, I don't know if there is other repercussion.

[mahagr]

Looks like I've already fixed this in 6a9724d#diff-a387dc90668050191ec659f1e145f5e0R34

[mahagr]

@rhukster Do we need to backport this one or is it ok to have it fixed only in Grav 1.7?

[mahagr]

Cherry picked the fix to Grav 1.6 as well.

[mhlsf]

This fix does work, thank you !