Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having a plugin/theme in a folder with the same name of a GPM package one, triggers an update #765

Closed
3 tasks done
flaviocopes opened this issue Apr 4, 2016 · 3 comments

Comments

@flaviocopes
Copy link
Contributor

flaviocopes commented Apr 4, 2016

Issue coming from users following the Theme Tutorial being prompted by Grav to update the theme as there was a newer version available, because the theme is built in a bootstrap folder, and we have a "Bootstrap" theme in GPM that installs there.

After adding the bootstrap.yaml file, Grav thinks the theme is from the GPM and needs an update, saying

You are running Bootstrap v1.4.1 [updatable: v1.4.1]

We should at least:

  • First, change the tutorial theme folder, to avoid confusion for new users getgrav/grav-learn@8884963
  • Avoid Grav prompting for an update if there's no blueprints.yaml file in the theme, which indicates the version installed PR Ready
  • Should we also add a special field to a theme/blueprint to indicate it's not from the GPM? Like private: true or gpm: false or <suggest better name here> PR Ready
@flaviocopes
Copy link
Contributor Author

PR #767 addresses this problem, introducing a check on gpm: false in the theme/plugin blueprint, and also avoid trying to update if no version is specified in the blueprint, which means it's not a package published on the GPM.

@rhukster
Copy link
Member

rhukster commented Apr 4, 2016

  • Also want to rewrite the tutorial in question to use the new 'prime-blank' theme i put together for the CLI dev tools.

@flaviocopes
Copy link
Contributor Author

Closing as the issue in code is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants