dateRange without end date problem

[Sogl]

Hello!

This issue related to:
#274
#275

I'm trying to show some posts from blog to in a home modular page depending to start date and found a bug with dateRange filter. Blog has 2 posts with 2013 and 2016 years.

My section frontmatter.yaml:

events:
    items:
        '@page': '/events'
    dateRange:
        start: 1/1/2012
        end: 1/1/2017

Markdown:

{% set events_collection = page.collection('events') %}

{% for event in events_collection %}
    <p>{{ event.title }}</p>
{% endfor %}

With this settings I see both posts, it's fine.

But without end date in frontmatter.yaml:

events:
    items:
        '@page': '/events'
    dateRange:
        start: 1/1/2012

I see no posts at all.

Env:

• Grav v1.1.0-rc.1

[flaviocopes]

Mmm I tried but I can't replicate, it works fine to me.

[Sogl]

It replicates also with field: header.date.

How to see full request to my /events?

[flaviocopes]

What's an example of a child page? Do you define the date there?

[Sogl]

What's an example of a child page? Do you define the date there?

title: Post with a Background Image
date: 25.10.2013

I don't know what happened, but it's working on my home Mac machine after git pull 😕
Cache is always disabled.

Need to check on Windows machine where it happen.

[rhukster]

Please check the Grav version specifically, see if they are in sync.

[flaviocopes]

Yep I also got it working by using the format of the child page you use (setting the date manually)

[Sogl]

Please check the Grav version specifically, see if they are in sync.

Versions are equal. I'm using one git repo with full site copy.

Hah... it reproduces on my Windows machine in the same way. No matter what date format is setting in post.

p.s. Just updated to Grav v1.1.0-rc.2 without no effect to this issue.

[Sogl]

I think I found a spot where problem starts:
https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Page/Collection.php#L273

Setting end: now +21 years is working, but end: now +22 years is not.

$date = date('d-m-Y', strtotime('now +21 years'));
echo $date . "<br>"; //15-06-2037
$date = date('d-m-Y', strtotime('now +22 years'));
echo $date; //01-01-1970

Specifications:
https://secure.php.net/manual/en/function.strtotime.php#refsect1-function.strtotime-notes

Strange, because I'm using PHP 5.6 x64.

[flaviocopes]

Ok so this problem is specific to 32-bit systems, where the dates end on 2038-01-19 03:14:07, and 22 years point us over that date - would have never thought about that.

Testing the PR

[flaviocopes]

Merged PR