Don't truncate HTML if content length is less than summary size #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhukster
requested changes
Oct 23, 2016
Sanity check
|
Hi @rhukster, good call. I couldn't see anywhere else in the codebase where TruncateHtml was called, but placing the sanity check in the Utils:truncateHtml makes sense going forward. I have updated my pull request. |
flaviocopes
approved these changes
Oct 24, 2016
dliessi
added a commit
to dliessi/grav
that referenced
this pull request
May 2, 2018
The original fix provided by getgrav#1125 in Utils::truncateHTML compared the summary size with the full HTML string length. Thus, the string was still being truncated (and the HTML rewritten) even when only the HTML string length, and not the text length, exceeded the summary size.
dliessi
added a commit
to dliessi/grav
that referenced
this pull request
May 4, 2018
The original fix provided by getgrav#1125 in Utils::truncateHtml compared the summary size with the full HTML string length. Thus, the string was still being truncated (and the HTML rewritten) even when only the HTML string length, and not the text length, exceeded the summary size.
rhukster
pushed a commit
that referenced
this pull request
May 15, 2018
* Move fix for #1114 to Truncator::truncateLetters The original fix provided by #1125 in Utils::truncateHtml compared the summary size with the full HTML string length. Thus, the string was still being truncated (and the HTML rewritten) even when only the HTML string length, and not the text length, exceeded the summary size. * Add fix for #1114 also to Truncator::truncateWords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1114 by comparing size of
$contentagainst the summary size. If a$contentis short and doesn't require a summary to be generated, return it's original form.