Ensure Windows-compliant filenames #1361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an array of disallowed ($illegal) characters, and does a simple str_replace on filename prior to writing the package, in InstallCommand->downloadPackage().
Because PCRE is a single line, and virtually faster.
|
@OleVik I see this fix is only in the GPM CLI command, is this not an issue when installing/updating on windows via admin? |
|
I found it.. updated myself, going to test... |
|
Good point, hadn't tested from Admin. |
rhukster
added a commit
that referenced
this pull request
Mar 20, 2017
rhukster
referenced
this pull request
in getgrav/grav-plugin-admin
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an array (
$illegal) of disallowed characters, and does a simplestr_replaceon filename prior to writing the package to /tmp, in InstallCommand->downloadPackage(). Source: SO and MSDN, tested on Windows 10 x64, PHP v7.0.7 ran via Caddy v0.9.3.Other considerations could be added to
$illegal, but at current they are superfluous. Did not instantiate as a Class-property as only downloadPackage() runsfile_put_contents.