Fixed routing issues with multisite and multilanguage #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like unit tests do not like my change to move some code to its proper location. I will change it back (soon) and tackle the issue later in 2.0. |
|
I think some of these have been made in 1.4 already, if not, it's too far out of date as it stands. |
…e/multisite-route # Conflicts: # system/src/Grav/Common/Page/Pages.php # system/src/Grav/Common/Processors/InitializeProcessor.php # system/src/Grav/Common/Twig/TwigExtension.php # system/src/Grav/Common/Uri.php
|
I have updated the pull request. Looks like we still need these changes, though there may be a better way to do them in v1.4 as I've added some classes which will help on routing. |
…e/multisite-route
|
Closed as there's a new version of this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1501 -- remember to add changelog entry on merge.