fix Twig dynamic translation #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahagr
requested changes
Aug 23, 2017
| @@ -374,6 +374,9 @@ public function translate($args, array $languages = null, $array_support = false | |||
| { | |||
| if (is_array($args)) { | |||
| $lookup = array_shift($args); | |||
| if (is_array($args)) { | |||
There was a problem hiding this comment.
$args is still an array, no need to check it again.
There was a problem hiding this comment.
You're right, in fact, just the one line with array_shift
|
thanks |
ghost
deleted the
|
Thank you all |
rhukster
added a commit
that referenced
this pull request
Aug 28, 2017
This addresses issues with the PR. It uses a new twig filter that gives full access to the langauges->translate() function.
|
Actually I had to revert this as it broke sprintf style text replacement in translations. I've created a new twig filter/function that will allow you to do translations in other languages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my PR
A little for my poor english, a bit because I thought the solution was not exhaustive (the presence of the other two arguments: array_support and html_out) I hesitated to do this PR. I've done the tests I find necessary, I think it's okay 😄