Propagate error code if between 400 and 600 for production sites #2181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2164.
The code is only propagated if both of the following are true, otherwise the default 500 is thrown:
system:errors:display
is0
or-1
The first condition is necessary because when verbosity is
1
, it uses the built-in Whoops handler. The only way to override (that I can find) is to create our ownPrettyPageHandler
that inherits from the built-in one and that contains the propagation code. But I wanted a minimal solution for now. I am happy to take the next step if this approach is acceptable.I tested this by throwing a new
RuntimeException
inGrav\Common\Twig\Twig::processSite
. I also tested throwing with no code. Certainly more tests are necessary, but I don't know enough about the possible repercussions.Let me know if you'd like me to make further changes.