Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php 8.1 to test #3504

Merged
merged 1 commit into from
Jan 11, 2022
Merged

add php 8.1 to test #3504

merged 1 commit into from
Jan 11, 2022

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Dec 25, 2021

@rhukster rhukster merged commit fb2c4f4 into getgrav:develop Jan 11, 2022
@Rotzbua Rotzbua deleted the patch-1 branch January 11, 2022 18:44
@mdestafadilah
Copy link

'mbstring' extension is not loaded. This is required for Grav to run correctly.

grav use 'ext-mbstring'.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 11, 2022

That is not correct, even if the doc claims it:
https://learn.getgrav.org/17/basics/requirements#php-requirements

The truth is that the extension mbstring is just optional:

grav/composer.json

Lines 78 to 79 in 2c252c4

"suggest": {
"ext-mbstring": "Recommended for better performance",

Because of the polyfill:

"symfony/polyfill-mbstring": "~1.23",

If this is really a problem there must be at least one single test failing.

@mdestafadilah
Copy link

@Rotzbua hi, i see too.. but i'm testing it in heroku.

any update here?

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 11, 2022

@mdestafadilah I am not familiar with your setup nor your use case. The best is to create a detailed issue or provide a proper solution as pull request.

@mdestafadilah
Copy link

@mdestafadilah I am not familiar with your setup nor your use case. The best is to create a detailed issue or provide a proper solution as pull request.

hems. may your self test it with fresh install to heroku. in my own server still using PHP 8.0 for production but at heroku using PHP 8.1 for development.

just wait others to test it.

@mahagr
Copy link
Member

mahagr commented Feb 14, 2022

@mdestafadilah Error should be fixed now, but I recommend installing the PHP extension as it is much faster.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 14, 2022

@mdestafadilah Stop pointing at me. Stop trying to make your problems to my problems. If you are too lazy to create a proper issue it is your fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants