Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add phpdocs with deprecated #3546

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add phpdocs with deprecated #3546

wants to merge 2 commits into from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Feb 27, 2022

Needed for IDE and linter support.

mahagr
mahagr requested changes Feb 28, 2022
View reviewed changes
Copy link
Member

@mahagr mahagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make them internal instead of deprecated for now. Some of those are still being used before Grav initialization.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 28, 2022

I do not understand.

Your own comment claims:

grav/system/defines.php

Line 73 in 3dd0cab

// DEPRECATED: Do not use!

Deprecation just means that the variables should not be used for new code and old code should be refactored in the future.
I see no contradiction between the current use and documenting a deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahagr mahagr mahagr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rotzbua @mahagr