Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This allows a frontmatter.yaml file to be included in a page folder #775

Merged
merged 4 commits into from
Apr 13, 2016

Conversation

rhukster
Copy link
Member

@rhukster rhukster commented Apr 6, 2016

any 'frontmatter.yaml` file will be merged into the page header.

Caveats with this approach:

With this approach, in the admin this will be merged in transparently and shows up as if it were in the page frontmatter itself, and then when you save, it is in fact saved back into the page.

Doing anything else differently is going to be much more complex because we'll have to handle two ways of generating header data (one for admin ignoring this file, and one for frontend). However it's not even that easy because this data is potentially cached, meaning we'll have to maintain two versions in cache, leading to possible inconsistencies.

This is a pretty advanced feature and would not be something that could be set via Admin so am not sure if this is a problem or not.

Also it is fine if you use Expert mode because that reads and saves the frontmatter in the page header directly.

@rhukster
Copy link
Member Author

rhukster commented Apr 6, 2016

This PR is regarding Issue #757

@rhukster
Copy link
Member Author

Ok i've found a solution to my caveat, i've actually set it so the cache on admin is independent of site. This should fix some other obscure issues too.

@rhukster rhukster merged commit 3535c55 into develop Apr 13, 2016
@flaviocopes flaviocopes deleted the feature/default-frontmatter-yaml branch June 9, 2016 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants