Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

an attempt to add support for elixir #593

Merged
merged 6 commits into from
Jan 3, 2025
Merged

an attempt to add support for elixir #593

merged 6 commits into from
Jan 3, 2025

Conversation

setop
Copy link
Contributor

@setop setop commented Dec 31, 2024 •
edited by morgante
Loading

Towards #556

@morgante morgante marked this pull request as ready for review January 3, 2025 03:41
@morgante morgante requested a review from a team as a code owner January 3, 2025 03:41
@morgante
Copy link
Contributor

morgante commented Jan 3, 2025

Thanks @setop, I took a quick look and pushed some fixes. Here's some nuance:

  • It looks like ^ is a reserved symbol in Elixir, so it's probably not a good choice for metavariables. $ seems like it should work and is our usual default
  • In the metavariable grammar, named fields will be needed to add for anywhere we want match.

@morgante morgante merged commit eee3a81 into getgrit:main Jan 3, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@setop @morgante