Guesstimates in models get copied hundreds of times

[OAGr]

There seems to be a bug where instead of the input field getting saved over the previously saved value, sometimes it gets saved as well as the previously saved value. Because multiple guesstimates are allowed for one metric, this can mean that one model can get hundreds or thousands of guesstimates, even if there are few models. This results in gigantic models that basically crash the server.

This should be fixed.

One additional longer-term feature would be the creation of a yaml or json editor, so at least the user can see what is happening and fix it quickly.

[AanandHQ]

Thanks for the explanation Ozzie, this makes sense based on data iterations I see when the model loads (e.g. cell values changing). Hope we are able to resolve this issue and add the editor for longer term fixes.

[OAGr]

This is where I think the problem is, in the 'CHANGE_GUESSTIMATE' section
https://github.com/getguesstimate/guesstimate-app/blob/master/src/modules/guesstimates/reducer.js#L12

[AanandHQ]

Yeah I think you may be right, not sure you are able to fix this from your end? Happy to amend the code from my end if possible/required. However, if a proper fix is possible I'd really appreciate it.

[OAGr]

I can fix it, just in the middle of another challenge. Trying to fix something else before getting to this (some user login issues)

[AanandHQ]

Thanks Ozzie! Really cool to see all the updates and fixes happening post-haste. FYI I'm already an adoring fan of Guesstimate 🤓

[AanandHQ]

Hi Ozzie,

Sorry to be a pain but still getting the issue, not sure if you were able to attempt a fix?

Many thanks,

Aanand

On 10 Feb 2016, at 22:24, Ozzie Gooen notifications@github.com wrote:

I can fix it, just in the middle of another challenge. Trying to fix something else before getting to this (some user login issues)

—
Reply to this email directly or view it on GitHub #85 (comment).

[OAGr]

I spent some time with it, realizing I need to fix a larger issue to ensure
it will work. Have spent the past bunch of hours trying to figure out the
best way, will get to it tomorrow.

On Thursday, February 11, 2016, AanandHQ notifications@github.com wrote:

Hi Ozzie,

Sorry to be a pain but still getting the issue, not sure if you were able
to attempt a fix?

Many thanks,

Aanand

On 10 Feb 2016, at 22:24, Ozzie Gooen <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I can fix it, just in the middle of another challenge. Trying to fix
something else before getting to this (some user login issues)

—
Reply to this email directly or view it on GitHub <
#85 (comment)
.

—
Reply to this email directly or view it on GitHub
#85 (comment)
.

[AanandHQ]

No worries Ozzie,

Thanks I’ll wait for you to get back to me before logging in and messing it up any further :)

Best of luck with it man, and if you need code monkey to help out, holla' at me!

Aanand

On 11 Feb 2016, at 09:11, Ozzie Gooen notifications@github.com wrote:

I spent some time with it, realizing I need to fix a larger issue to ensure
it will work. Have spent the past bunch of hours trying to figure out the
best way, will get to it tomorrow.

On Thursday, February 11, 2016, AanandHQ notifications@github.com wrote:

Hi Ozzie,

Sorry to be a pain but still getting the issue, not sure if you were able
to attempt a fix?

Many thanks,

Aanand

On 10 Feb 2016, at 22:24, Ozzie Gooen <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I can fix it, just in the middle of another challenge. Trying to fix
something else before getting to this (some user login issues)

—
Reply to this email directly or view it on GitHub <
#85 (comment)
.

—
Reply to this email directly or view it on GitHub
#85 (comment)
.

—
Reply to this email directly or view it on GitHub #85 (comment).

[OAGr]

Hi,

I think this should have fixed the main issue: #86

It doesn't fix any old models that have problems. However, if you can load these into your browser, then edit them, when they get saved then they should be fine.

[AanandHQ]

Hi Ozzie,

Gave it a go and its all running much better, hopefully the fix has sorted out the issue on the long-term.

Cheers!

Aanand

On 12 Feb 2016, at 09:21, Ozzie Gooen notifications@github.com wrote:

Hi,

I think this should have fixed the main issue: #86 #86
It doesn't fix any old models that have problems. However, if you can load these into your browser, then edit them, when they get saved then they should be fine.

—
Reply to this email directly or view it on GitHub #85 (comment).

[OAGr]

Glad to hear!

I made a similar fix on the server side. If no one complains about it soon, I'll make that one permanent, waiting to see if anyone will experience issues with it.

[AanandHQ]

Great stuff! hopefully you’ll be issue-free from the user-side of things.

On 12 Feb 2016, at 20:16, Ozzie Gooen notifications@github.com wrote:

Glad to hear!

I made a similar fix on the server side. If no one complains about it soon, I'll make that one permanent, waiting to see if anyone will experience issues with it.

—
Reply to this email directly or view it on GitHub #85 (comment).