Fix: Quicklaunch duplicating services in the list

[denispapec]

Proposed change

When using quicklaunch, and deleting some letters and writing again; it starts to duplicate the same services in the list (as the UL object reuses the same key).

Type of change

• New service widget
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation only
• Other (please explain)

Checklist:

• If adding a service widget or a change that requires it, I have added corresponding documentation changes.
• If adding a new widget I have reviewed the guidelines.
• If applicable, I have checked that all tests pass with e.g. pnpm lint.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

[shamoon]

2135.mov

Again, I cant reproduce this. Also doesnt make sense to me the key should be on the ul but rather the li's, which already have keys

[denispapec]

Again, I cant reproduce this.

Ah, another clue is that service needs to be added multiple times on homepage, for example: multiple PiHole widgets, multiple Portainer widgets, multiple Watchtower widgets....

Also doesnt make sense to me the key should be on the ul but rather the li's, which already have keys

Yeah, that's what I went to fix at first, but adding key to UL seems to resolve this issue.

[shamoon]

I think that only happens if they have the same name, which is explicitly something we discourage.

2135_2.mov

Btw, using random numbers for react keys is definitely not best practice

Let me know if Im missing anything here. Thanks anyway.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.