Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate Chinese translations for wanStatus field in pfSense widget #4441

Closed
wants to merge 2 commits into from

Conversation

KuuDS
Copy link

@KuuDS KuuDS commented Dec 19, 2024

Proposed change

In the pfSense widget, the Chinese translations for the wanStatus field values up and down are inaccurate.

The current translations are '上传' (which means upload) and '下载' (which means download).
I have replaced them with '连接' (which means Connected) and '断开' (which means Disconnected) respectively.

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

This change only involves I18n modifications and does not affect functionality.

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@KuuDS KuuDS closed this Dec 19, 2024
@shamoon
Copy link
Collaborator

shamoon commented Dec 19, 2024

Thanks, yea all translation stuff is handled via crowdin

@KuuDS
Copy link
Author

KuuDS commented Dec 19, 2024

Thanks, yea all translation stuff is handled via crowdin

Sorry, I was a bit hasty. After submitting the draft, I found that the pfsense-related translations are included in zh-CN, zh-Hans, and zh-Hant. The translations in zh-Hans and zh-Hant are correct. We need to confirm whether to remove the translation in zh-CN or to correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants