Enhancement: add duration format to customapi widget

[morgendagen]

Proposed change

This PR adds a duration format to the customapi widget. This allows formatting durations (in seconds) in to a more human-readable format, e.g. 1h20m instead of 4,850.

Type of change

• New service widget
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation only
• Other (please explain)

Checklist:

• If applicable, I have added corresponding documentation changes.
• If applicable, I have reviewed the feature and / or service widget guidelines.
• I have checked that all code style checks pass using pre-commit hooks and linting checks.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

[shamoon]

Both the fact that this isn’t linked to a discussion and that it fails linting suggest that you ticked the boxes above but didn’t really read / do them... which is sorta disappointing.

I really thought this would make it clear enough, but I guess not.

In the spirit of collaboration, please respect the guidelines for projects to which you would like to contribute.

Please reopen this if / when the guidelines are met.

[morgendagen]

Hi,

You are incorrect in your assumption that I did not read, understand, and try to adhere by the rules set forth, and I am sorry that you decided to close this PR without giving me an opportunity to fix the linter issue.

I did not realise that I was committing in a shell where pre-commit hadn't been installed, and assumed that the pre-commit hooks had been executed. As soon as an email popped up in my inbox about a failed workflow, I fixed the issue and was about to push the change when your comment above arrived.

The reason for not opening a feature request / starting a discussion on this PR was based on the word should instead of must combined with the fact that I felt this was such a small change that would have no ongoing maintenance associated with it as it was using an existing feature (common.duration) that is already being utilized elsewhere.

I guess I'll just use my own fork of the project going forward, a project that I have found quite useful.

Have a nice day.

[shamoon]

Sorry for being reactionary. I shouldn’t review PRs after work. If you’d like to correct the lint that would be fine.

[shamoon]

Apologies again.

Thanks

[morgendagen]

Hi,

My sincere apologies for messing up for not catching the linter issue myself and thank you very much for accepting this PR. Your work on this project is very much appreciated :-)