Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: quick launch not showing nested services #4561

Merged

Conversation

DeepSpace2
Copy link
Contributor

@DeepSpace2 DeepSpace2 commented Jan 5, 2025

Proposed change

Fix for quick launch not showing nested services.

The issue can be reproduced with the following services.yaml, and then searching for "c" only shows NonNestedCalendar.

- NonNested:
  - NonNestedCalendar:
      href: http://google.com
      widget:
        type: calendar

- NestedParent:
  - Nested:
    - NestedCalendar:
        href: http://google.com
        widget:
          type: calendar

- NestedNestedParent:
  - Nested1:
    - Nested2:
      - DoubleyNestedCalendar:
          href: http://google.com
          widget:
            type: calendar

- NestedNestedNestedParent:
  - NestedNestedParent:
    - Nested1:
      - Nested2:
        - FullyNestedCalendar:
            href: http://google.com
            widget:
              type: calendar

image

After this fix, searching for "c" finds both the non nested and all the nested services:

fixed

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this can just be simplified a tiny bit more

src/pages/index.jsx Outdated Show resolved Hide resolved
@shamoon shamoon enabled auto-merge (squash) January 5, 2025 15:51
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
auto-merge was automatically disabled January 5, 2025 15:53

Head branch was pushed to by a user without write access

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@shamoon shamoon merged commit 2f7d948 into gethomepage:main Jan 5, 2025
@shamoon shamoon changed the title Fix: quick launch not showing nested services Fix: quick launch not showing nested services Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants