-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: ephemeral keys #13
Feature: ephemeral keys #13
Conversation
Hi @SignSpice, |
@lucassousaf You're welcome! I was not able to find the comment you left. Could you send me a link or post it here? |
16ffa44
to
208e2d9
Compare
@lucassousaf Do you have any insight on the failing build on travis? All the tests pass when I run them locally. But the travis build doesn't even get so far as running the tests, if I understand it correctly. |
Hello @SignSpice, it seems that the problem with the Travis CI failing was due to a change in the OpenJDK 8 image, and it affects old versions of |
@lucassousaf Okay. Is there another option for submitting the signed license agreement? I am on Linux, and the online version of word doesn't work with the form inputs, and LibreOffice doesn't seem to let me submit the form either. |
Okay, now the build is running the tests, but the ephemeral keys test is failing because I set the test to try to pull the stripe api verison out of an environment variable. So the build config would need to be changed for it to pass as is. I could set the test to a hard-coded default too, I suppose. IE. Does that sound good to you? |
Okay! I added the |
@SignSpice, yes, you can follow the instruction of the CLA assistant above. No need for submitting the files. We'll eventually update the contribution guidelines to address this issue. Thank you! |
52263fe
to
aa43a0a
Compare
Not sure this is the best way to go about implementing this feature - I am new to Clojure.
I was unable to find the official documentation for this on the stripe website, doesn't seem to exist. Although it is mentioned in some of the guides, such as this one: https://stripe.com/docs/payments/accept-a-payment?platform=react-native#react-native-add-server-endpoint