Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ephemeral keys #13

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

SignSpice
Copy link
Contributor

Not sure this is the best way to go about implementing this feature - I am new to Clojure.

I was unable to find the official documentation for this on the stripe website, doesn't seem to exist. Although it is mentioned in some of the guides, such as this one: https://stripe.com/docs/payments/accept-a-payment?platform=react-native#react-native-add-server-endpoint

@lucassousaf
Copy link
Contributor

Hi @SignSpice,
Thank you very much for your work!
I left one comment on your changes. Once it is fixed, before merging the changes, we need you to first sign a Contribution License Agreement following our contributing guideline
Thanks in advance!

@SignSpice
Copy link
Contributor Author

@lucassousaf You're welcome!

I was not able to find the comment you left. Could you send me a link or post it here?

@SignSpice SignSpice force-pushed the feature-ephemeral-keys branch from 16ffa44 to 208e2d9 Compare March 2, 2022 00:19
@SignSpice
Copy link
Contributor Author

@lucassousaf Do you have any insight on the failing build on travis? All the tests pass when I run them locally. But the travis build doesn't even get so far as running the tests, if I understand it correctly.

@lucassousaf
Copy link
Contributor

Hello @SignSpice, it seems that the problem with the Travis CI failing was due to a change in the OpenJDK 8 image, and it affects old versions of http-kit. So, I upgraded the library version (just pushed the changes to the main branch) to the latest and the CI is working again.

@SignSpice
Copy link
Contributor Author

@lucassousaf Okay. Is there another option for submitting the signed license agreement? I am on Linux, and the online version of word doesn't work with the form inputs, and LibreOffice doesn't seem to let me submit the form either.

@SignSpice
Copy link
Contributor Author

Okay, now the build is running the tests, but the ephemeral keys test is failing because I set the test to try to pull the stripe api verison out of an environment variable. So the build config would need to be changed for it to pass as is. I could set the test to a hard-coded default too, I suppose. IE.
(or (System/getenv "STRIPE_API_VERSION") "2020-08-27")

Does that sound good to you?

@lucassousaf
Copy link
Contributor

lucassousaf commented Mar 3, 2022

Okay, now the build is running the tests, but the ephemeral keys test is failing because I set the test to try to pull the stripe api verison out of an environment variable. So the build config would need to be changed for it to pass as is. I could set the test to a hard-coded default too, I suppose. IE. (or (System/getenv "STRIPE_API_VERSION") "2020-08-27")

Does that sound good to you?

Okay! I added the STRIPE_API_VERSION in the build config. So we won't need that hardcoded API version.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2022

CLA assistant check
All committers have signed the CLA.

@lucassousaf
Copy link
Contributor

@lucassousaf Okay. Is there another option for submitting the signed license agreement? I am on Linux, and the online version of word doesn't work with the form inputs, and LibreOffice doesn't seem to let me submit the form either.

@SignSpice, yes, you can follow the instruction of the CLA assistant above. No need for submitting the files. We'll eventually update the contribution guidelines to address this issue. Thank you!

@SignSpice SignSpice force-pushed the feature-ephemeral-keys branch from 52263fe to aa43a0a Compare March 3, 2022 22:53
@lucassousaf lucassousaf merged commit aece797 into gethop-dev:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants