Fix for compatibility with Kedro 0.18.4 onwards #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…megaConfigLoader which replaced the legacy ConfigLoader and TemplatedConfigLoader previously used. Updates also allow for backwards integration for versions of kedro <= 0.18.4. Updates also added user flexibility for choice of docker image platform architecture which allows for multi-architecture docker images. As a result of the codebase changes updates to the affected unit tests were made.
astrojuanlu
reviewed
Jan 7, 2025
Comment on lines
+11
to
+13
| import kedro | ||
| from kedro.framework.session import KedroSession | ||
| from packaging import version |
There was a problem hiding this comment.
You might want to use importlib.metadata instead of relying on packaging.version and kedro.__version__ https://docs.python.org/3.9/library/importlib.metadata.html#metadata
There was a problem hiding this comment.
Sure happy to make that change. What is the benefit of doing it that way rather than using packaging.version?
There was a problem hiding this comment.
Using packaging.version might be unavoidable if you want to parse it. The key is how to obtain the currently installed version, and importlib.metadata is the canonical way I'd say. See pallets/flask#5230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to allow integration with kedro 0.18.4 > onwards which uses OmegaConfigLoader which replaced the legacy ConfigLoader and TemplatedConfigLoader previously used. Updates also allow for backwards integration for versions of kedro <= 0.18.4.
Updates also added user flexibility for choice of docker image platform architecture which allows for multi-architecture docker images.
As a result of the codebase changes updates to the affected unit tests were made.
This is my first PR for a public codebase so any feedback or comments is appreciated :)