Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readOnly validation causing backwards incompatibility #689

Closed
simonjpartridge opened this issue Dec 1, 2022 · 3 comments · Fixed by #758
Closed

readOnly validation causing backwards incompatibility #689

simonjpartridge opened this issue Dec 1, 2022 · 3 comments · Fixed by #758

Comments

@simonjpartridge
Copy link

The addition of validation for readOnly #599 has caused issues for our existing clients when calling our API.

Especially in the flow where a user does a put update, they end up incidentally sending readOnly parameters to the API.

x = GetX
x.Value = "updated"
UpdateX(x)

Ideally I think the readOnly validation should be optional with a configuration option.

Would you be open to this change if we were to raise a PR to implement it?

@fenollp
Copy link
Collaborator

fenollp commented Dec 2, 2022

Sure! Send away :)

@gczobel
Copy link

gczobel commented Jan 29, 2023

It's someone working right now on this? @simonjpartridge I can take this if you are not actively working on it.

@orshlom
Copy link
Contributor

orshlom commented Jan 31, 2023

Hey @fenollp, please review the PR when you got the time 😏

I have made writeOnly properties validation configurable as well.

@fenollp fenollp linked a pull request Feb 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants